Lior Vernia has posted comments on this change. Change subject: webadmin: Improve VM interface explanatory text ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/25004/3/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java: Line 99: @DefaultMessage("default: {0}") Line 100: String defaultTimeZoneCaption(String currentDefault); Line 101: Line 102: @DefaultMessage("Instantiate VM network interfaces by picking a vNIC profile.") Line 103: String assignNics(); > Should move to CommonApplicationConstants Done Line 104: Line 105: @DefaultMessage("<Empty>") Line 106: SafeHtml emptyProfile(); Line 107: http://gerrit.ovirt.org/#/c/25004/3/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.java: Line 56 Line 57 Line 58 Line 59 Line 60 > You removed the initialization of vnics. Done -- To view, visit http://gerrit.ovirt.org/25004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79d0d3d62f48c1d56292e65f5087a7a7100e118a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
