Alon Bar-Lev has posted comments on this change.

Change subject: tools: remove log4j usage from engine-config
......................................................................


Patch Set 1:

All ok, but I do not understand:

> 4) Add --log4j-config which will contain user defined configuration and which 
> won't be
altered by us at all

why does it conflicts with 1, 2, 3? we just load this instead of whatever in 
jar.

-- 
To view, visit http://gerrit.ovirt.org/26305
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc4eadac817e0527d1286e277b4500f83526c6f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to