Arik Hadas has posted comments on this change. Change subject: core: fix support for pattern-based name for pool ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26356/1//COMMIT_MSG Commit Message: Line 6: Line 7: core: fix support for pattern-based name for pool Line 8: Line 9: Adding the validation group 'CreateEntity' to UpdateVmPoolWithVmsCommand Line 10: caused a regression that prevented to set pattern-based name for pool. > any way to add a test to avoid this regressing again? Done (yes we can!) Line 11: The problem was that the validation which is declared on Line 12: VmStatic#getName was checked also for pools and it doesn't accept name Line 13: that contains '?'. Line 14: -- To view, visit http://gerrit.ovirt.org/26356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bfa9fb37d464dd0e77b0bc206c1804713ed9575 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
