Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: NFS config on update change ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26370/1/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py: Line 95 Line 96 Line 97 Line 98 Line 99 Why the following is not enough? if self.environment[osetupcons.SystemEnv.NFS_CONFIG_ENABLED] is None: if not self.environment[osetupcons.DBEnv.NEW_DATABASE]: self.environment[osetupcons.SystemEnv.NFS_CONFIG_ENABLED] = False -- To view, visit http://gerrit.ovirt.org/26370 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fb4a9eb4af5e811a1fa1a63b8c11126b01ae56c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
