Liron Ar has posted comments on this change. Change subject: core: ISO Storage Domain can be detached for suspended VM. ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26309/1//COMMIT_MSG Commit Message: Line 6: Line 7: core: ISO Storage Domain can be detached for suspended VM. Line 8: Line 9: Since the VM process is not running when the VM is suspended, we should Line 10: allow the user to detach the ISO Storage Domain, even if the VM is 1. in this patch you allowed to deactivate it - fix the message. 2. IMO we should at least add an audit log with warning to the user that while this domain is on maintenance those vm won't be able to function properly. 3. have you checked that the vm will function fine if the domain is activated again? even after operations that we allow to do on domain in maintenance mode were done? (for example, editing it's path). 3. If you enable it for suspended, what about hibernated vms? 5. (unrelated to this patch) actually seems like we have a bug on the detach command, user can detach a iso domain even if there are vms that "uses" it. Line 11: suspended. Line 12: Line 13: Change-Id: I3d6c75fccada58d9a537c94040b0eb86b3332e3f -- To view, visit http://gerrit.ovirt.org/26309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d6c75fccada58d9a537c94040b0eb86b3332e3f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Xavi Francisco <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
