Omer Frenkel has posted comments on this change. Change subject: backend: bugfix in VdsManager on failedToRunVm ......................................................................
Patch Set 4: Code-Review+1 (1 comment) right, i thought the timer is always active. Roy, any comments? http://gerrit.ovirt.org/#/c/26139/4/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 483: if (vds.getStatus() == VDSStatus.Error) { Line 484: mFailedToRunVmAttempts.set(0); Line 485: setStatus(VDSStatus.Up, vds); Line 486: DbFacade.getInstance().getVdsDynamicDao().updateStatus(getVdsId(), VDSStatus.Up); Line 487: log.infoFormat("onVdsDuringFailureTimer of Host {0} entered after {1} attempts to run a VM", does it still make sense to log the attempts? it will always be 0 Line 488: vds.getName(), Line 489: mFailedToRunVmAttempts); Line 490: } Line 491: } -- To view, visit http://gerrit.ovirt.org/26139 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4dd140ceecf4954e65ea3f6174a41acea82f6a6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
