Yedidyah Bar David has posted comments on this change. Change subject: core: Add executePipe ......................................................................
Patch Set 16: > but if this works it is the ultimate execute function... :) Don't be too proud - I already thought of a missing feature: Let the callback get some more info about the status as to try to give some more meaningful progress indication. E.g. number of bytes read/written to/from each fd. Not urgent, though :-) Seriously, I think it can be quite useful for the case for which we currently wrote this. On restore of a compressed sql file, you can know exactly the size of the input to psql (sadly if we default to bzip2 we do not have 'gzip -l' which works well usually) and so can try to estimate the percent done by dividing the number of bytes written by bzip2 (or read by psql) with the total size. Yaniv/Barak were concerned especially about large DBs where restore can take days. I think they'll like such a feature. -- To view, visit http://gerrit.ovirt.org/26213 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a434fbe1308ac2f603b8ae09756354c11138912 Gerrit-PatchSet: 16 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
