Dan Kenigsberg has posted comments on this change. Change subject: packaging: add required packages... ......................................................................
Patch Set 4: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/26330/4/ovirt-release.spec.in File ovirt-release.spec.in: Line 57: %make_install Line 58: #Allow ghost files Line 59: install -d 755 "%{buildroot}%{_sysconfdir}"/yum.repos.d Line 60: touch "%{buildroot}%{_sysconfdir}"/yum.repos.d/ovirt.repo Line 61: touch "%{buildroot}%{_sysconfdir}"/yum.repos.d/ovirt-el-deps.repo We do not ever expect to see both ovirt-el-deps and ovirt-f19-deps on a single host. At least one is always empty. Having a single ovirt-deps.repo would create less noise and dirt on target hosts. Line 62: touch "%{buildroot}%{_sysconfdir}"/yum.repos.d/ovirt-f19-deps.repo Line 63: Line 64: %post Line 65: Line 85: if [ "$DIST" == "EL" ] ; then Line 86: install -m 644 "%{_datadir}/%{package_name}/ovirt-el-deps.repo" "%{_sysconfdir}/yum.repos.d/ovirt-el-deps.repo" Line 87: fi Line 88: Line 89: if rpm --eval "%%dist" | grep -qFi 'fc19'; then Why run `rpm --eval` again? You already have DISTVER ready. Since this new condition is mutually exclusive of the former EL one, it makes sense to join them with "elsif". Line 90: install -m 644 "%{_datadir}/%{package_name}/ovirt-f19-deps.repo" "%{_sysconfdir}/yum.repos.d/ovirt-f19-deps.repo" Line 91: fi Line 92: Line 93: Line 86: install -m 644 "%{_datadir}/%{package_name}/ovirt-el-deps.repo" "%{_sysconfdir}/yum.repos.d/ovirt-el-deps.repo" Line 87: fi Line 88: Line 89: if rpm --eval "%%dist" | grep -qFi 'fc19'; then Line 90: install -m 644 "%{_datadir}/%{package_name}/ovirt-f19-deps.repo" "%{_sysconfdir}/yum.repos.d/ovirt-f19-deps.repo" We still have a little problem with what to do when the admin upgrades from f19 to f20, where this file is no longer needed. We could call this condition again from within %triggerpost -- fedora-release So that we no longer pull stuff from virt-preview needlessly. At least that's what a puritan would say, just to prove the point that having a f19-specific build is the "right thing" to do. I'm not sure that it is worth the trouble. Line 91: fi Line 92: Line 93: Line 94: -- To view, visit http://gerrit.ovirt.org/26330 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib357d7066970496e94f45e19b931fe7b381ef1bc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
