Allon Mureinik has posted comments on this change. Change subject: core: Disallow domains of mixed subtype (file/block) in <3.4 storage pool ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/26366/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java: Line 226: // TODO: Should be removed when 3.0 compatibility will not be supported, for now we are blocking the possibility Line 227: // to mix NFS domains with block domains on 3.0 pools since block domains on 3.0 pools can be in V2 format while NFS Line 228: // domains on 3.0 can only be in V1 format Line 229: protected boolean isMixedTypesAllowedInDC() { Line 230: return getStoragePool().getcompatibility_version().compareTo(Version.v3_3) > 0; Shouldn't this just return FeatureSupported.mixedDomainTypesOnDataCenter ? Line 231: } Line 232: Line 233: public boolean isMixedTypeDC(StorageDomain storageDomain) { Line 234: boolean isBlockDomain = storageDomain.getStorageType().isBlockDomain(); -- To view, visit http://gerrit.ovirt.org/26366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8226c29e6c34ab6434d0a5ec07aa7fa1d4d00306 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
