Maor Lipchuk has uploaded a new change for review. Change subject: core: Add vdc query of getUnregisteredVMs ......................................................................
core: Add vdc query of getUnregisteredVMs Adding a new vdc query to get all the VMs which are unregistered by storage domain id. WIP : Tests should be added Change-Id: If6282c06913a6aff38d88b12497a24643bb73e35 Signed-off-by: Maor Lipchuk <[email protected]> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredVmsQuery.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IdAndNameQueryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 63 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/82/26482/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredVmsQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredVmsQuery.java new file mode 100644 index 0000000..9511fdd --- /dev/null +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredVmsQuery.java @@ -0,0 +1,28 @@ +package org.ovirt.engine.core.bll; + +import java.util.ArrayList; +import java.util.List; + +import org.ovirt.engine.core.common.businessentities.OvfEntityData; +import org.ovirt.engine.core.common.businessentities.VM; +import org.ovirt.engine.core.common.queries.IdAndNameQueryParameters; + +public class GetUnregisteredVmsQuery<P extends IdAndNameQueryParameters> extends QueriesCommandBase<P> { + public GetUnregisteredVmsQuery(P parameters) { + super(parameters); + } + + @Override + protected void executeQueryCommand() { + List<VM> vmList = new ArrayList<>(); + List<OvfEntityData> entityList = getDbFacade() + .getUnregisteredOVFDataDao().getAllForStorageDomain(getParameters().getId(), getParameters().getName()); + for (OvfEntityData ovf : entityList) { + VM vm = new VM(); + vm.setId(ovf.getVmId()); + vm.setName(ovf.getVmName()); + vmList.add(vm); + } + getQueryReturnValue().setReturnValue(vmList); + } +} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IdAndNameQueryParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IdAndNameQueryParameters.java new file mode 100644 index 0000000..67a5bc2 --- /dev/null +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IdAndNameQueryParameters.java @@ -0,0 +1,34 @@ +package org.ovirt.engine.core.common.queries; + +import org.ovirt.engine.core.compat.Guid; + +public class IdAndNameQueryParameters extends VdcQueryParametersBase { + private static final long serialVersionUID = 8906662143775124331L; + + private Guid id; + private String name; + + public IdAndNameQueryParameters() { + } + + public IdAndNameQueryParameters(Guid id, String name) { + this.id = id; + this.name = name; + } + + public Guid getId() { + return id; + } + + public void setId(Guid id) { + this.id = id; + } + + public String getName() { + return name; + } + + public void setName(String name) { + this.name = name; + } +} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java index 3a42d45..34be2e4 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java @@ -8,6 +8,7 @@ GetVmByVmId(VdcQueryAuthType.User), GetVmByVmNameForDataCenter(VdcQueryAuthType.User), GetAllVms(VdcQueryAuthType.User), + GetUnregisteredVms(VdcQueryAuthType.User), GetVmsRunningOnOrMigratingToVds, GetVmsByStorageDomain, GetVmCustomProperties(VdcQueryAuthType.User), -- To view, visit http://gerrit.ovirt.org/26482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If6282c06913a6aff38d88b12497a24643bb73e35 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
