Roy Golan has posted comments on this change. Change subject: Adding RHEL7 Guest support ......................................................................
Patch Set 1: (2 comments) so pending the next patchset and verification. btw - is there only a 64 bit version for RHEL 7? http://gerrit.ovirt.org/#/c/26351/1/packaging/conf/osinfo-defaults.properties File packaging/conf/osinfo-defaults.properties: Line 131: os.rhel_6x64.devices.audio.value = ich6 Line 132: os.rhel_6x64.devices.diskInterfaces.value.3.3 = IDE, VirtIO_SCSI, VirtIO Line 133: os.rhel_6x64.devices.diskInterfaces.value.3.4 = IDE, VirtIO_SCSI, VirtIO Line 134: Line 135: # rhel7x64(19, OsType.Linux, true), > missed it -> Done you can completely remove the comment. I initially created a comment with the "old" enum representation of the Vm so for new records which came after osinfo introduction this doesn't make sense. I'll soon remove all of them (the comments with the id) since we feel comfortable enough now with what we have. Line 136: os.rhel_7x64.id.value = 24 Line 137: os.rhel_7x64.name.value = Red Hat Enterprise Linux 7.x x64 Line 138: os.rhel_7x64.derivedFrom.value = rhel_6x64 Line 139: os.rhel_7x64.devices.audio.value = ich6 Line 137: os.rhel_7x64.name.value = Red Hat Enterprise Linux 7.x x64 Line 138: os.rhel_7x64.derivedFrom.value = rhel_6x64 Line 139: os.rhel_7x64.devices.audio.value = ich6 Line 140: os.rhel_7x64.devices.diskInterfaces.value.3.3 = IDE, VirtIO_SCSI, VirtIO Line 141: os.rhel_7x64.devices.diskInterfaces.value.3.4 = IDE, VirtIO_SCSI, VirtIO > Yeah they are, I just looked at the wrong thing. thanks Line 142: Line 143: # WindowsXP(1, OsType.Windows, false), Line 144: os.windows_xp.id.value = 1 Line 145: os.windows_xp.name.value = Windows XP -- To view, visit http://gerrit.ovirt.org/26351 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaddd08e730898fc526f11c1c8c9371fed7801038 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
