Alon Bar-Lev has posted comments on this change. Change subject: core: Add executePipe ......................................................................
Patch Set 21: (1 comment) http://gerrit.ovirt.org/#/c/26213/21/src/otopi/plugin.py File src/otopi/plugin.py: Line 399: end_time += datetime.timedelta(seconds=timeout) Line 400: Line 401: popens = [] Line 402: try: Line 403: fds = {} > why have you moved the fds initialization? >> why have you moved the fds initialization? > Because the exception needs it... It will fail e.g. if you try to execute a non-existing program - popen will fail and fds will not be initialized and fail the exception. so it should be outside the try...near the popens. Line 404: stdindata = None Line 405: if ( Line 406: stdin is None or Line 407: isinstance(stdin, bytes) or -- To view, visit http://gerrit.ovirt.org/26213 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a434fbe1308ac2f603b8ae09756354c11138912 Gerrit-PatchSet: 21 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
