Alon Bar-Lev has posted comments on this change. Change subject: aaa: using the new extensions API in InternalDirectory ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/26477/7/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/DirectoryProxy.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/DirectoryProxy.java: Line 139: ExtMap result = outputMap.get(Authz.InvokeKeys.QUERY_RESULT); Line 140: if (result == null) { Line 141: break; Line 142: } Line 143: handler.handle(result); > well, here i'm not searching for some element, but have to iterate on all t I just want generic functions to be reusable... if you invest the effort... thinking of one more minor change for use case can help reduce future issues. Line 144: } Line 145: return results; Line 146: } finally { Line 147: extension.invoke(new ExtMap().mput( -- To view, visit http://gerrit.ovirt.org/26477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I958443292da0455e0a12039fac98eebb9b17dee2 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
