Yaniv Dary has posted comments on this change.

Change subject: reports: br21 report - added comments to queries
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/25136/5/packaging/ovirt-reports/resources/Reports/Inventory/Storage_Domain_Report_BR21_files/Storage_Domain_Report_BR21_jrxml.data
File 
packaging/ovirt-reports/resources/Reports/Inventory/Storage_Domain_Report_BR21_files/Storage_Domain_Report_BR21_jrxml.data:

Line 65:         v3_4_configuration_history_storage_domains.storage_domain_id =
Line 66:         
v3_4_statistics_storage_domains_resources_usage_$P!{table_name}.storage_domain_id
Line 67:         -- Here we filter by the storage domain chosen by the user
Line 68:         AND 
v3_4_statistics_storage_domains_resources_usage_$P!{table_name}.storage_domain_id
 =
Line 69:         CASE $P{P_StorageDomain_ID}
This should be indented with another tab.
Line 70:             WHEN NULL
Line 71:                 THEN NULL
Line 72:             WHEN '11111111-1111-1111-1111-111111111111'
Line 73:                 THEN NULL


-- 
To view, visit http://gerrit.ovirt.org/25136
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6011ea7812ab7abdf5367da5f61c44a8bc2d6d3c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <[email protected]>
Gerrit-Reviewer: Shirly Radco <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to