Yair Zaslavsky has posted comments on this change. Change subject: aaa: using the extension API at InternalDirectory ......................................................................
Patch Set 13: (3 comments) http://gerrit.ovirt.org/#/c/26477/13/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalDirectory.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalDirectory.java: Line 24: new HashSet<>(Arrays.asList( Line 25: Authz.InvokeCommands.QUERY_PRINCIPALS_BY_IDS_OPEN, Line 26: Authz.InvokeCommands.QUERY_PRINCIPALS_OPEN, Line 27: Authz.InvokeCommands.QUERY_PRINCIPALS_BY_IDS_OPEN, Line 28: Authz.InvokeCommands.QUERY_GROUPS_BY_IDS_OPEN) > what with groups_open? oops, done :) Line 29: ); Line 30: Line 31: private ExtMap context; Line 32: Line 76: ); Line 77: } Line 78: } Line 79: Line 80: private void doQueryExecute(ExtMap input, ExtMap output) { > not that important as the engine will ignore principal if it looks for grou no, this is how engine acts today, we can argue if it is alright, but i do not want to break this behavior at the moment . any search returns the admin user for admin authz. Line 81: Opaque opaque = input.<Opaque> get(Authz.InvokeKeys.QUERY_OPAQUE); Line 82: output.put(Authz.InvokeKeys.QUERY_RESULT, opaque.firstCall ? Arrays.asList(adminUser) : null); Line 83: opaque.firstCall = false; Line 84: } Line 96: Base.ContextKeys.EXTENSION_NAME, Line 97: "Internal Authorization (Built-in)" Line 98: ).mput( Line 99: Base.ContextKeys.INSTANCE_NAME, Line 100: context.<Properties> get(Base.ContextKeys.CONFIGURATION).get(Base.ConfigKeys.NAME) > the extensions manager should put the instance name. Done Line 101: ).mput( Line 102: Base.ContextKeys.LICENSE, Line 103: "ASL 2.0" Line 104: ).mput( -- To view, visit http://gerrit.ovirt.org/26477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I958443292da0455e0a12039fac98eebb9b17dee2 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
