Yair Zaslavsky has posted comments on this change. Change subject: aaa: InternalAuthenticator should use the extension API ......................................................................
Patch Set 17: (1 comment) http://gerrit.ovirt.org/#/c/26443/17/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthenticator.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthenticator.java: Line 46: Line 47: private void doInit(ExtMap input, ExtMap output) { Line 48: context = input.<ExtMap> get(Base.InvokeKeys.CONTEXT); Line 49: List<String> sensitiveKeys = new ArrayList<>(context.<List<String>> get(Base.ContextKeys.CONFIGURATION_SENSITIVE_KEYS)); Line 50: sensitiveKeys.add("config.authn.user.password"); > done Arrays.asList returns a Arrays.ArrayList - a class that it's "add" method is unsupported (feel free to say "bad java") as a result you must wrap it with ArrayList, in order to add the additional entry. Yes, You can use one of the tricks you suggested before, but IMHO, this adds more lines in code, than just using a temp variable here, taking back the "done" comment, unfortunately. Line 51: Line 52: context.mput( Line 53: Base.ContextKeys.AUTHOR, Line 54: "The oVirt Project").mput( -- To view, visit http://gerrit.ovirt.org/26443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60f7b7f50617bff9f4872dc79f14fb016c9d72d3 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
