Shirly Radco has posted comments on this change. Change subject: reports: edited ic query-only_vms_vm_list ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/26306/2/packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_VMs/P_VM_ListID.xml File packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_VMs/P_VM_ListID.xml: Line 82: CAST ( $P{P_DataCenter_ID} AS uuid ) Line 83: ) Line 84: --Here we filter by the clusters chosen by the user Line 85: AND v3_4_configuration_history_vms.cluster_id = Line 86: CASE $P{P_Cluster_ID} > Should be indented with one more tab Done Line 87: WHEN '11111111-1111-1111-1111-111111111111' Line 88: THEN v3_4_configuration_history_vms.cluster_id Line 89: ELSE CAST ( $P{P_Cluster_ID} AS uuid ) Line 90: END Line 89: ELSE CAST ( $P{P_Cluster_ID} AS uuid ) Line 90: END Line 91: --Here we filter by the vm types chosen by the user Line 92: AND v3_4_configuration_history_vms.vm_type = Line 93: CASE CAST ( $P{P_VM_Type} AS int ) > also Done Line 94: WHEN -1 Line 95: THEN v3_4_configuration_history_vms.vm_type Line 96: WHEN NULL Line 97: THEN v3_4_configuration_history_vms.vm_type -- To view, visit http://gerrit.ovirt.org/26306 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26c447e2705a2ef91d6c9f9e44d5b6b266c9f3a1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
