Alon Bar-Lev has posted comments on this change. Change subject: Split ovirt-release to per version packages. ......................................................................
Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/26564/7/ovirt-release-3.4/ovirt-release.spec.in File ovirt-release-3.4/ovirt-release.spec.in: Line 100: %{_datadir}/%{package_name}/ Line 101: %ghost %config(noreplace) %{_sysconfdir}/yum.repos.d/ovirt.repo Line 102: %ghost %config(noreplace,missingok) %{_sysconfdir}/yum.repos.d/fedora-virt-preview.repo Line 103: %ghost %config(noreplace,missingok) %{_sysconfdir}/yum.repos.d/glusterfs-epel.repo Line 104: %ghost %config(noreplace,missingok) %{_sysconfdir}/yum.repos.d/ovirt-epel.repo why ghost? BTW: the note for the gluster was generic... we need to have different names for all the files and repos to avoid conflict with our other package. Line 105: Line 106: %changelog Line 107: * Mon Apr 07 2014 Kiril Nesenko <[email protected]> - 11.1.0-1.1 Line 108: - Update nightly repos Line 101: %ghost %config(noreplace) %{_sysconfdir}/yum.repos.d/ovirt.repo Line 102: %ghost %config(noreplace,missingok) %{_sysconfdir}/yum.repos.d/fedora-virt-preview.repo Line 103: %ghost %config(noreplace,missingok) %{_sysconfdir}/yum.repos.d/glusterfs-epel.repo Line 104: %ghost %config(noreplace,missingok) %{_sysconfdir}/yum.repos.d/ovirt-epel.repo Line 105: ok... if we outline all repo explicitly, we should have it without version within the source tree, but install it with version at repo... this way we can diff better the source tree. Line 106: %changelog Line 107: * Mon Apr 07 2014 Kiril Nesenko <[email protected]> - 11.1.0-1.1 Line 108: - Update nightly repos Line 109: -- To view, visit http://gerrit.ovirt.org/26564 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c2fefb53ac5bac2bea512c573b636a5da1a0aa8 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
