Yaniv Dary has posted comments on this change. Change subject: reports: br14 report - added comments to queries ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/26348/4/packaging/ovirt-reports/resources/Reports/Service_level/VMs/virtual_servers_uptime_br14_files/br14_table.jrxml.data File packaging/ovirt-reports/resources/Reports/Service_level/VMs/virtual_servers_uptime_br14_files/br14_table.jrxml.data: Line 94: WHERE datacenter_id = CAST ( $P{P_DataCenter_ID} AS uuid ) Line 95: ) Line 96: -- Here we filter by the cluster chosen by the user Line 97: AND v3_4_configuration_history_vms.cluster_id = Line 98: CASE $P{P_Cluster_ID} This needs to be indented by one more tab Line 99: WHEN NULL Line 100: THEN v3_4_configuration_history_vms.cluster_id Line 101: WHEN '11111111-1111-1111-1111-111111111111' Line 102: THEN v3_4_configuration_history_vms.cluster_id Line 127: ) Line 128: -- Here we get or remove deleted entities according to what the user chose Line 129: -- in the "is_deleted" parameter. Line 130: $P!{is_deleted} Line 131: GROUP BY v3_4_configuration_history_vms.cluster_id, single space instead of double Line 132: v3_4_configuration_history_vms.vm_id, Line 133: v3_4_configuration_history_vms.vm_name, Line 134: CASE Line 135: WHEN v3_4_configuration_history_vms.delete_date IS NULL -- To view, visit http://gerrit.ovirt.org/26348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76efaad98171ad2bcf05bbf8acb3a2306aee88c6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
