Roy Golan has posted comments on this change.

Change subject: core: integrate make into maven
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/25661/1/mavenmake/pom.xml
File mavenmake/pom.xml:

Line 35:                 <artifactId>exec-maven-plugin</artifactId>
Line 36:                 <version>1.2.1</version>
Line 37:                 <executions>
Line 38:                     <execution>
Line 39:                         <phase>install</phase>
> well its more intuitive. its really a deploy.
but the "maven" deploy term if for delivering the artifact to a remote (maven) 
repository. so I'm pretty this doesn't fit. 
unless we maven allow to override the behavior of deploy mojo
Line 40:                         <goals>
Line 41:                             <goal>exec</goal>
Line 42:                         </goals>
Line 43:                     </execution>


-- 
To view, visit http://gerrit.ovirt.org/25661
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8981f04b26a2d36429f8bfccaada8dfbadfbf9c3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to