Alexander Wels has posted comments on this change. Change subject: core, engine, webadmin: Shutdown/power off operations on a VM would ask for an optional reason ......................................................................
Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/25633/13/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java: Line 72: private boolean trustedService; Line 73: Line 74: private boolean haReservation; Line 75: Line 76: private boolean vmStopReasonRequired; > vmStopReasonRequired isn't a cluster field- that's user configuration, plea I might be missing something here, I am not sure what controls this field, but storing something in 'LocalStorage' will only store the value in the browser. So any other browser will not have that value. I am not sure if that is what the desired behaviour is. If it is, getting local storage is something you would use on the presenter/view level, not in the entities. Line 77: Line 78: private Guid clusterPolicyId; Line 79: Line 80: private String clusterPolicyName; -- To view, visit http://gerrit.ovirt.org/25633 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17645e5bc97a1a4d460956ec45f88524465dfd7b Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
