Martin Peřina has posted comments on this change. Change subject: core: Add common methods for runtime log4j setup ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/26588/2/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/log/Log4jUtils.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/log/Log4jUtils.java: Line 59: FileAppender fa = null; Line 60: try { Line 61: fa = new FileAppender(new PatternLayout("%d %-5p [%c] %m%n"), fileName, true); Line 62: fa.setThreshold(level); Line 63: } catch (SecurityException | IOException ex) { > can we please resume to this discussion? OK, Done. Line 64: throw new IllegalArgumentException( Line 65: String.format("Error accessing log file '%s': '%s'", fileName, ex.getMessage()), Line 66: ex); Line 67: } -- To view, visit http://gerrit.ovirt.org/26588 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic00ea0af643e8c978fd67eb8c56e2329d43e776d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
