Omer Frenkel has posted comments on this change. Change subject: backend: Add support for Vm Boot Menu ......................................................................
Patch Set 3: (1 comment) looks ok, one comment http://gerrit.ovirt.org/#/c/26126/3/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 241: select fn_db_add_config_value('BootMenuSupported','false','3.0'); Line 242: select fn_db_add_config_value('BootMenuSupported','false','3.1'); Line 243: select fn_db_add_config_value('BootMenuSupported','false','3.2'); Line 244: select fn_db_add_config_value('BootMenuSupported','false','3.3'); Line 245: select fn_db_add_config_value('BootMenuSupported','false','3.4'); i didnt see where you use this config? Line 246: Line 247: -- by default use no proxy Line 248: select fn_db_add_config_value('SpiceProxyDefault','','general'); Line 249: -- To view, visit http://gerrit.ovirt.org/26126 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I415f9ce2c20f1f80fea314c587b68a8db2a956b0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
