Kiril Nesenko has posted comments on this change.

Change subject: Split ovirt-release to per version packages.
......................................................................


Patch Set 12:

(2 comments)

http://gerrit.ovirt.org/#/c/26564/12/ovirt-release-3.4/configure.ac
File ovirt-release-3.4/configure.ac:

Line 29: AC_INIT([ovirt-release34], VERSION_NUMBER[]VERSION_SUFFIX, 
[[email protected]])
Line 30: 
Line 31: PACKAGE_RPM_VERSION="VERSION_NUMBER"
Line 32: PACKAGE_RPM_RELEASE="0.1.$(echo VERSION_SUFFIX | sed 's/^_//')"
Line 33: OVIRT_SLOT="OVIRT_RELEASE"
> just set:
ah i see .... ok ok
Line 34: AC_SUBST([PACKAGE_RPM_VERSION])
Line 35: AC_SUBST([PACKAGE_RPM_RELEASE])
Line 36: AC_SUBST([OVIRT_SLOT])
Line 37: 


http://gerrit.ovirt.org/#/c/26564/12/ovirt-release-3.4/ovirt-release.spec.in
File ovirt-release-3.4/ovirt-release.spec.in:

Line 89: %ghost %config(noreplace) 
%{_sysconfdir}/yum.repos.d/ovirt-%{ovirt_version}.repo
Line 90: %ghost %config(noreplace) 
%{_sysconfdir}/yum.repos.d/ovirt-%{ovirt_version}-dependencies.repo
Line 91: 
Line 92: %changelog
Line 93: * Thu Apr 10 2014 Kiril Nesenko <[email protected]> - 
1.0.0-0.1.master 
> please fix
Done


-- 
To view, visit http://gerrit.ovirt.org/26564
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c2fefb53ac5bac2bea512c573b636a5da1a0aa8
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: David Caro <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to