Yevgeny Zaspitsky has posted comments on this change. Change subject: engine: add audit log warning when display network is set and a running VM is attached to the cluster (for AttachNetworksToCluster command). ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/26504/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java: Line 205: Line 206: getReturnValue().getCanDoActionMessages().addAll(messages); Line 207: return false; Line 208: } Line 209: > when method on a class like this have to be static to be available to anoth I agree with you that static methods is not very good practice. I'll do that refactoring in a separate patch when I'll have a time. Line 210: public static void updateNetworkAttachment( Line 211: Guid clusterId, Line 212: NetworkCluster networkCluster, Line 213: Network network, -- To view, visit http://gerrit.ovirt.org/26504 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I674f7f7a905e3007e9857dd817e125e52d02c448 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
