anmolbabu has posted comments on this change. Change subject: ui-plugin : Trends Tab ......................................................................
Patch Set 19: (4 comments) http://gerrit.ovirt.org/#/c/25471/19/gluster-nagios-dashboard/gluster-nagios-dashboard.json File gluster-nagios-dashboard/gluster-nagios-dashboard.json: Line 1: { Line 2: "name": "AngularTest", > Name should be GlusterNagiosDashboard Ya I just copy pasted Vojtech's code.And just made enough changes to make it work.I'll change this in my next patch :D Line 3: "url": "plugin/AngularTest/start.html", Line 4: "resourcePath": "test-resources", Line 5: "config": { Line 6: "ApplicationMode": "1", Line 5: "config": { Line 6: "ApplicationMode": "1", Line 7: "messageOrigins":["http://localhost.localdomain:8080"; , "http://10.70.1.124:8080"; , "http://10.3.224.100:8080";] , Line 8: "pnp4nagiosUrl" : "http://10.3.12.50/pnp4nagios/image?"; , Line 9: "engineUrl" : "http://localhost.localdomain:8080/"; > I think engineUrl is not required, as you could access using relative path Done.Ya ,I am currently using relative urls as you told me. Line 10: } http://gerrit.ovirt.org/#/c/25471/19/gluster-nagios-dashboard/src/js/trends.js File gluster-nagios-dashboard/src/js/trends.js: Line 15: }, Line 16: appendTimeToUrl : function(url , startTimeString , endTimeString) { Line 17: return url + "&start=" + startTimeString + "&end=" + endTimeString; Line 18: } Line 19: }; > Use space instead of tab Done.This is the eclipse auto-indent.yes,I'll change the indentation. Line 20: }]); Line 21: Line 22: mod.factory('dataManager', ['$window', '$rootScope', 'graphUtils', '$http', function ($window, $rootScope, graphUtils, $http) { Line 23: var treeItemType, treeItemEntityId, treeItemEntityName, treeItemClusterId, configObject; http://gerrit.ovirt.org/#/c/25471/19/gluster-nagios-dashboard/src/trendsTab.html File gluster-nagios-dashboard/src/trendsTab.html: Line 5: <script src="http://ajax.googleapis.com/ajax/libs/angularjs/1.2.8/angular.js";></script> Line 6: <script src="http://angular-ui.github.io/bootstrap/ui-bootstrap-tpls-0.10.0.js";></script> Line 7: <script src="js/trends.js"></script> Line 8: <link href="//netdna.bootstrapcdn.com/bootstrap/3.0.3/css/bootstrap.min.css" rel="stylesheet"> Line 9: <script src="js/common.js"></script> > scripts should be picked from local instead of web Done Line 10: </head> Line 11: <body ng-controller="tabController"> Line 12: <img style="padding-top : 9px ; padding-left : 10px" ng-repeat="graph in graphs" ng-src="{{graph}}"/> Line 13: <!-- <pre>Selected date is: <em>{{dt | date:'fullDate' }}</em></pre> --> -- To view, visit http://gerrit.ovirt.org/25471 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7c00636e380da154f7f457066fe89475d04c9b4 Gerrit-PatchSet: 19 Gerrit-Project: samples-uiplugins Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
