Xiaolei Shi has posted comments on this change. Change subject: engine: Numa feature entities ......................................................................
Patch Set 14: (2 comments) Modified according to the conclusion of the sync-up meeting http://gerrit.ovirt.org/#/c/23702/14/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java: Line 150: private List<VdsNumaNode> numaNodeList; Line 151: Line 152: private String numaNodeDistance; Line 153: Line 154: private Boolean autoNumaBalancing; > it was just a thought, open for discussion :) how you're going to use it? It will be an enum which contains three values of enable, disable and unknown. Because it's a kernel configuration, the value will be unknown once we can't get this kernel parameter. Line 155: Line 156: public void setVersion(RpmVersion value) { Line 157: rpmVersion = value; Line 158: } http://gerrit.ovirt.org/#/c/23702/14/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsNumaNodeStatistics.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsNumaNodeStatistics.java: Line 5: /** Line 6: * Object which represents host NUMA node statistics information Line 7: * Line 8: */ Line 9: public class VdsNumaNodeStatistics implements Serializable { > I disagree on that. please elaborate. As the agreement in the meeting, will rename this class. Line 10: Line 11: private static final long serialVersionUID = 3274786304152401306L; Line 12: Line 13: private long memFree; -- To view, visit http://gerrit.ovirt.org/23702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifefade432e7955503980bdc6fc5d73ea32818a95 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Leonardo Bianconi <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: Xiaolei Shi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
