Moti Asayag has posted comments on this change. Change subject: engine: Consider custom properties in Setup Networks ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/26646/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java: Line 139: } Line 140: Line 141: private void extractModifiedInterfaces() { Line 142: for (VdsNetworkInterface nic : params.getInterfaces()) { Line 143: VdsNetworkInterface existingNic = getExistingIfaces().get(nic.getName()); > I know this is not part of change, but isn't it weird, that existing NICs a How did you observe that the existing nics are queried multiple times from the DB ? By looking at private Map<String, VdsNetworkInterface> getExistingIfaces() { ... } The nics seem to be cached. Line 144: if (existingNic != null) { Line 145: Set<String> newLabels = NetworkUtils.isLabeled(nic) ? nic.getLabels() : Collections.<String> emptySet(); Line 146: Set<String> existingLabels = Line 147: NetworkUtils.isLabeled(existingNic) ? existingNic.getLabels() : Collections.<String> emptySet(); -- To view, visit http://gerrit.ovirt.org/26646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic607fb6073f2c4c0a4790763d9a09dc7879f11ca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
