Juan Hernandez has posted comments on this change. Change subject: restapi: Add flag to detect kdump before fencing ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26721/1/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java: Line 165: } Line 166: } Line 167: } Line 168: } Line 169: entity.setPmKdumpDetection(model.isKdumpDetection()); Here we should support situations where the caller didn't provide the "kdump_detection", otherwise the call to "isKdumpDetection" will return null and then the call to "setPmKdumpDetection" will try to unbox it and produce a NPE: if (model.isSetKdumpDetection()) { entity.setPmKdumpDetection(model.isKdumpDetection()); } Line 170: return entity; Line 171: } Line 172: Line 173: /** -- To view, visit http://gerrit.ovirt.org/26721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3208e62cbca121a741fb83d9fafd37935df9c1ba Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
