Tomas Jelinek has posted comments on this change. Change subject: webadmin: ListModelTypeAheadListBox to not always add to valid values ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26747/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java: Line 55: @UiField Line 56: Style style; Line 57: Line 58: private final SuggestBoxRenderer<T> renderer; Line 59: private final boolean autoAddToValidValues; please put a javadoc here - it is not that obvious what does this do and why to use it without knowing the context... Line 60: Line 61: private Collection<T> acceptableValues = new ArrayList<T>(); Line 62: Line 63: private HandlerRegistration eventHandler; -- To view, visit http://gerrit.ovirt.org/26747 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic35073123696fe7e727464079c31794935a7ad70 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
