Francesco Romani has posted comments on this change. Change subject: frontend: spice: expose support to control the user data transfer ......................................................................
Patch Set 15: (2 comments) http://gerrit.ovirt.org/#/c/26244/15/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java: Line 1930: Version.v3_3.compareTo(getSelectedCluster().getcompatibility_version()) <= 0; Line 1931: Line 1932: getBehavior().enableSinglePCI(isLinux && isQxl && clusterSupportsSinglePci); Line 1933: Line 1934: if (isQxl && getSelectedCluster() != null) { > imagine this flow: Good spot. Fixed. Line 1935: String clusterVersion = getSelectedCluster().getcompatibility_version().toString(); Line 1936: Line 1937: boolean spiceFileXferToggle = AsyncDataProvider.isSpiceFileXferToggleSupported(clusterVersion); Line 1938: getSpiceFileXferEnabled().setIsChangable(spiceFileXferToggle); Line 1935: String clusterVersion = getSelectedCluster().getcompatibility_version().toString(); Line 1936: Line 1937: boolean spiceFileXferToggle = AsyncDataProvider.isSpiceFileXferToggleSupported(clusterVersion); Line 1938: getSpiceFileXferEnabled().setIsChangable(spiceFileXferToggle); Line 1939: getSpiceFileXferEnabled().setIsAvailable(spiceFileXferToggle); > we are trying not to hide (setIsAvailable()) the fields but make them not e Thanks, done. Line 1940: Line 1941: boolean spiceCopyPasteToggle = AsyncDataProvider.isSpiceCopyPasteToggleSupported(clusterVersion); Line 1942: getSpiceCopyPasteEnabled().setIsChangable(spiceCopyPasteToggle); Line 1943: getSpiceCopyPasteEnabled().setIsAvailable(spiceCopyPasteToggle); -- To view, visit http://gerrit.ovirt.org/26244 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99f9f2f878171746c613598d80fdc9fdd3208ed2 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
