Lior Vernia has uploaded a new change for review.

Change subject: webadmin: Change height of label widgets
......................................................................

webadmin: Change height of label widgets

Played around with the heights to make dialogs related to the label
widgets look tighter.

Change-Id: Iff2e5474b4d407380f713a9f1312e778cfb9c446
Bug-Url: https://bugzilla.redhat.com/1030955
Signed-off-by: Lior Vernia <[email protected]>
---
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostNicPopupView.ui.xml
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.ui.xml
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksBondPopupView.java
3 files changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/55/26755/1

diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostNicPopupView.ui.xml
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostNicPopupView.ui.xml
index 32445c8..7b9398d 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostNicPopupView.ui.xml
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostNicPopupView.ui.xml
@@ -4,7 +4,7 @@
        xmlns:d="urn:import:org.ovirt.engine.ui.common.widget.dialog"
        
xmlns:h="urn:import:org.ovirt.engine.ui.webadmin.section.main.view.popup.host">
 
-       <d:SimpleDialogPanel width="400px" height="400px" >
+       <d:SimpleDialogPanel width="400px" height="215px" >
                <d:content>
                        <h:NicLabelWidget ui:field="labelsWidget" />
                </d:content>
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.ui.xml
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.ui.xml
index a6da61c..0c7eda3 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.ui.xml
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.ui.xml
@@ -29,7 +29,7 @@
 
        <g:FlowPanel addStyleNames="{style.mainPanel}" >
                <g:Label text="{constants.labelsHostPopup}" 
addStyleNames="{style.labelStyle}" />
-               <g:ScrollPanel height="249px">
+               <g:ScrollPanel height="124px">
                        <g:FlowPanel ui:field="contentPanel" />
                </g:ScrollPanel>
        </g:FlowPanel>
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksBondPopupView.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksBondPopupView.java
index cd6edf0..d5b68f6 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksBondPopupView.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksBondPopupView.java
@@ -5,6 +5,7 @@
 import org.ovirt.engine.ui.webadmin.ApplicationResources;
 import 
org.ovirt.engine.ui.webadmin.section.main.presenter.popup.host.SetupNetworksBondPopupPresenterWidget;
 
+import com.google.gwt.dom.client.Style.Overflow;
 import com.google.gwt.event.shared.EventBus;
 import com.google.inject.Inject;
 
@@ -29,7 +30,8 @@
         message.setVisible(false);
         // resize
         layoutPanel.remove(infoPanel);
-        asPopupPanel().setPixelSize(400, 400);
+        layoutPanel.getElement().getStyle().setOverflow(Overflow.HIDDEN);
+        asPopupPanel().setPixelSize(400, 275);
     }
 
     @Override


-- 
To view, visit http://gerrit.ovirt.org/26755
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff2e5474b4d407380f713a9f1312e778cfb9c446
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to