Alexander Wels has posted comments on this change. Change subject: webadmin,userportal: Persistent client-side logging infrastructure ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25444/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/AddOnlyRingBuffer.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/AddOnlyRingBuffer.java: Line 64: // Buffer is full, need to move the head Line 65: else { Line 66: int index = head; Line 67: head = (head + 1) % capacity; Line 68: old = delegate.read(index); > Note to reviewers: this might seem as redundant behavior, as it yields Loca The only strange thing here is that the return value is not what is added, but what is removed. At least it is consistent that it is the removed value. If you return the added value you can chain stuff on elements like javascript. Line 69: delegate.write(index, element); Line 70: } Line 71: Line 72: return old; -- To view, visit http://gerrit.ovirt.org/25444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b0be449ab425b56a1d7c39efeb1793991e58fa7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
