Sergey Gotliv has posted comments on this change. Change subject: restapi: Add REST API support for iSCSI multipathing ......................................................................
Patch Set 3: (3 comments) You are right, I will add tests. http://gerrit.ovirt.org/#/c/26225/3/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 4101: <xs:complexType name="IscsiBond"> Line 4102: <xs:complexContent> Line 4103: <xs:extension base="BaseResource"> Line 4104: <xs:sequence> Line 4105: <xs:element ref="data_center" minOccurs="0"/> > What is the default "maxOccurs"? Can you make it explicit? Both min and max occurs default values are 1. But you are right explicitly mention it will be better. I will do that. Line 4106: <xs:element ref="storage_connection" minOccurs="1" maxOccurs="unbounded" /> Line 4107: <xs:element ref="network" minOccurs="1" maxOccurs="unbounded" /> Line 4108: </xs:sequence> Line 4109: </xs:extension> Line 4122: <xs:element ref="iscsi_bond" minOccurs="0" maxOccurs="unbounded" /> Line 4123: </xs:sequence> Line 4124: </xs:extension> Line 4125: </xs:complexContent> Line 4126: </xs:complexType> > Please use two spaces for indentation, in all levels. Done Line 4127: Line 4128: <xs:element name="iscsi_bond" type="IscsiBond"/> Line 4129: Line 4130: <xs:element name="iscsi_bonds" type="IscsiBonds"/> http://gerrit.ovirt.org/#/c/26225/3/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml: Line 4924: body: Line 4925: parameterType: IscsiBond Line 4926: signatures: Line 4927: - mandatoryArguments: {} Line 4928: optionalArguments: {} > No parameters for update? Parameters that aren't documented here won't be r Great :-). Now I know the usage of that file. I'll do that! Line 4929: description: update the specified iSCSI Bond Line 4930: urlparams: {} Line 4931: headers: Line 4932: Content-Type: {value: application/xml|json, required: true} -- To view, visit http://gerrit.ovirt.org/26225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8881110cbeb163e9fc09e98bf4497d894f40490 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
