Juan Hernandez has posted comments on this change.
Change subject: restapi: Add CustomProperties member to HostNIC
......................................................................
Patch Set 3:
There is nothing wrong with this patch, but I would like to avoid using the
"custom_properties" element as much as possible. The reason is that the name
and value are represented as attributes, instead of elements, and that makes it
complicated to extend them in the future, for example to use long or multiple
values. Instead of reusing this element can we define a new one looking like
this?
<properties>
<property>
<name>the_name</name>
<value>the_value</value>
</property>
</properties>
There are some related comments about this here:
https://bugzilla.redhat.com/show_bug.cgi?id=1071872#c5
--
To view, visit http://gerrit.ovirt.org/26725
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1cd53d4e3fd0d2f0d7bec7f1a480679a31c6c8f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
