Alon Bar-Lev has posted comments on this change.

Change subject: restapi: Add CSRF protection filter
......................................................................


Patch Set 2:

jscript is optional component of openjdk, I do not believe that for masking ip 
address it worth to use optional JRE feature. A list of netmask should be 
sufficient and simple for this case.

For the cookie, can't you ijnect the cookie within filter so that J2EE will get 
that cookie based on input header?

-- 
To view, visit http://gerrit.ovirt.org/26578
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68f03eeefe5bcb1956036b4a80fef4400c467346
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to