Lior Vernia has posted comments on this change. Change subject: webadmin: Have minus button on every row in AddRemoveRowWidget ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/26879/2/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java: Line 196: Line 197: @Override Line 198: public void onClick(ClickEvent event) { Line 199: ListIterator<Pair<T, V>> last = items.listIterator(items.size()); Line 200: if (item == last.previous() && last.hasPrevious()) { > the last.previous() fails on NoSuchElementException if there is no previous Done Line 201: Pair<T, V> previousItem = last.previous(); Line 202: getEntry(previousItem.getSecond()).appendButton(createButton(previousItem, true)); Line 203: } Line 204: -- To view, visit http://gerrit.ovirt.org/26879 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f6af3c5a94f7786a9b1e6191f1c36d3181983cf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
