Martin Sivák has posted comments on this change. Change subject: use monotonic time when checking the timeouts ......................................................................
Patch Set 12: (2 comments) http://gerrit.ovirt.org/#/c/26384/12/ovirt_hosted_engine_ha/agent/states.py File ovirt_hosted_engine_ha/agent/states.py: Line 553: return super(EngineUpBadHealth, self).consume(fsm, new_data, logger) Line 554: Line 555: def score(self, logger): Line 556: # the timeout_start_time is None if the state just changed Line 557: time_str = time.ctime() Please put this into else part of the if. Line 558: if self.data.timeout_start_time: Line 559: time_str = time.ctime(self.data.timeout_start_time Line 560: + self.data.stats.time_epoch) Line 561: # If engine has bad health status, let another host try Line 625: Line 626: return EngineUnexpectedlyDown(new_data) Line 627: Line 628: def score(self, logger): Line 629: time_str = time.ctime() Please use else here as well. Line 630: if self.data.timeout_start_time: Line 631: time_str = time.ctime(self.data.timeout_start_time Line 632: + self.data.stats.time_epoch) Line 633: -- To view, visit http://gerrit.ovirt.org/26384 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9794beb4082f52d29835be5b6a182ab448c248f2 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
