Liran Zelkha has posted comments on this change. Change subject: core: Add selinux host info to VdsDynamic ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/26955/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java: Line 586: public void setPowerManagementControlledByPolicy(boolean powerManagementControlledByPolicy) { Line 587: this.powerManagementControlledByPolicy = powerManagementControlledByPolicy; Line 588: } Line 589: Line 590: public Integer getselinux_enforce_mode() { Please use Java standard naming convention - getSELinuxEnforceMode Line 591: return this.selinux_enforce_mode; Line 592: } Line 593: Line 594: public void setselinux_enforce_mode(Integer value) { http://gerrit.ovirt.org/#/c/26955/1/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java: Line 350: getObject rs.getInt, and no need for casting... -- To view, visit http://gerrit.ovirt.org/26955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If472f68702b59280c721450d4db50dc27dc19a30 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
