Alon Bar-Lev has posted comments on this change. Change subject: aaa: Adding interface build version ......................................................................
Patch Set 1: (1 comment) you can squash it into "Using extensions API" http://gerrit.ovirt.org/#/c/26971/1/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java: Line 321: "Instance name: '%1$s', Extension name: '%2$s', Version: '%3$s', Build interface Version: '%4$s', License: '%5$s', Home: '%6$s', Author '%7$s', File: '%8$s', Activated: '%9$s", Line 322: emptyIfNull(context.get(Base.ContextKeys.INSTANCE_NAME)), Line 323: emptyIfNull(context.get(Base.ContextKeys.EXTENSION_NAME)), Line 324: emptyIfNull(context.get(Base.ContextKeys.VERSION)), Line 325: emptyIfNull(context.get(Base.ContextKeys.BUILD_INTERFACE_VERSION)), why the extra indent? Line 326: emptyIfNull(context.get(Base.ContextKeys.LICENSE)), Line 327: emptyIfNull(context.get(Base.ContextKeys.HOME_URL)), Line 328: emptyIfNull(context.get(Base.ContextKeys.AUTHOR)), Line 329: entry.getFileName(), -- To view, visit http://gerrit.ovirt.org/26971 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05392555014bd0da87525a719c5628deb8c03d6e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
