Arik Hadas has posted comments on this change. Change subject: core: Removed redundant storage allocation checks ......................................................................
Patch Set 2: Vered, I'm not sure about this patch. I agree that we shouldn't check the correctness of storage validation as part of other commands, but removing all those tests means that we won't verify that we check the domain has enough free space when adding VM, right? I'm afraid that as part of possible regression we won't invoke the storage validation well and we won't catch it. why do these tests problematic for you? as long as the actual validations are made via the right validator it should be ok, or am I missing something? -- To view, visit http://gerrit.ovirt.org/26732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0e28f6cc8bd2834d6fe6ce6288a20946a69e9b3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
