Alon Bar-Lev has posted comments on this change. Change subject: aaa: Added usage of AuthRecord.VALID_TO ......................................................................
Patch Set 7: (4 comments) http://gerrit.ovirt.org/#/c/26975/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java: Line 217 Line 218 Line 219 Line 220 Line 221 why do you need this ^? Line 221: if (sessionTimeoutInterval > 0) { Line 222: SchedulerUtilQuartzImpl.getInstance().scheduleAFixedDelayJob(SessionDataContainer.getInstance(), Line 223: "cleanExpiredUsersSessions", new Class[] {}, new Object[] {}, Line 224: 1, Line 225: 1, TimeUnit.MINUTES); will this be every minute? or single instance in a minute? I do not know this api... Line 226: } Line 227: Line 228: // Set start-up time Line 229: _startedAt = DateTime.getNow(); http://gerrit.ovirt.org/#/c/26975/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/session/SessionDataContainer.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/session/SessionDataContainer.java: Line 165: removeSession(session); Line 166: } Line 167: validToSessionsMap.remove(key); Line 168: } Line 169: if (intervalsCounter.incrementAndGet() == Config.<Integer> getValue(ConfigValues.UserSessionTimeOutInterval)) { no... you should take the valid to. all the expiration logic should be applied with you calculate the valid to Line 170: deleteOldGeneration(); Line 171: intervalsCounter.set(0); Line 172: } Line 173: Line 169: if (intervalsCounter.incrementAndGet() == Config.<Integer> getValue(ConfigValues.UserSessionTimeOutInterval)) { Line 170: deleteOldGeneration(); Line 171: intervalsCounter.set(0); Line 172: } Line 173: - Line 174: } Line 175: Line 176: /** Line 177: * This method will add a user to thread local, at case that user is not -- To view, visit http://gerrit.ovirt.org/26975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53e4a371c1bae8d2480ddd2af921a560c6fe9a85 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
