Martin Betak has posted comments on this change. Change subject: restapi: Add Vm power-down options ......................................................................
Patch Set 2: (3 comments) Sorry about all the typos :( http://gerrit.ovirt.org/#/c/27047/2//COMMIT_MSG Commit Message: Line 12: <vm> Line 13: <power_down> Line 14: <force>true|false</force> Line 15: <timeout>[seconds]</timeout> Line 16: <user_delay>[seconds]</timeout> > The close tag should be </user_delay>. Done Line 17: </power_down> Line 18: </vm> Line 19: Line 20: timeout and user_delay are optional overrides of global settings so to http://gerrit.ovirt.org/#/c/27047/2/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml: Line 94: vm.cpu.cpu_tune.vcpu_pin--COLLECTION: {vcpu_pin.vcpu: 'xs:int', vcpu_pin.cpu_set: 'xs:string'} Line 95: vm.serial_number.policy: xs:string Line 96: vm.serial_number.value: xs:string Line 97: vm.bios.boot_menu.enabled: xs:boolean Line 98: vm.power_down.forced: xs:boolean > In the .xsd it is "force", without the "d" at the end. Done Line 99: vm.power_down.timeout: xs:int Line 100: vm.power_dowm.user_delay: xs:int Line 101: description: update the virtual machine in the system for the given virtual machine id with the values specified in the request Line 102: urlparams: {} http://gerrit.ovirt.org/#/c/27047/2/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java: Line 85: } Line 86: return features; Line 87: } Line 88: Line 89: private void addPowerDownOptionsFeatuer(Features features) { > s/Featuer/Feature/ Done Line 90: Feature feature = new Feature(); Line 91: feature.setName("VM PowerDown Options"); Line 92: feature.setDescription("Ability to specify force, timeout and user-delay options for VM shutdown/reboot"); Line 93: features.getFeature().add(feature); -- To view, visit http://gerrit.ovirt.org/27047 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1249f97c77a979466d4295f83bfb72f27ff630e3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
