Alon Bar-Lev has posted comments on this change. Change subject: aaa: introducing the new extension api ......................................................................
Patch Set 39: (2 comments) http://gerrit.ovirt.org/#/c/26435/39/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/Base.java File backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/Base.java: Line 110: * Set by extension during {@link InvokeCommands#INITIALIZE} to {@link #INTERFACE_VERSION_CURRENT}. Line 111: * @see InvokeCommands#INITIALIZE Line 112: * @see #INTERFACE_VERSION_CURRENT Line 113: */ Line 114: public static final ExtKey BUILD_INTERFACE_VERSION = new ExtKey("EXTENSION_BUILD_INTERFACE_VERSION", String.class, "cb479e5a-4b23-46f8-aed3-56a4747a8ab7"); this should be Integer Line 115: /** Line 116: * Extension's license. Line 117: * Set by extension. Line 118: * @see InvokeCommands#INITIALIZE http://gerrit.ovirt.org/#/c/26435/39/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Acct.java File backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Acct.java: Line 148: * Authorization's principal record. Line 149: * Optional. Line 150: * @see Authz.PrincipalRecord Line 151: */ Line 152: public static final ExtKey PRINCIPAL_RECORD = new ExtKey("AAA_ACCT_PRINCIPAL_RECORD_PRINCIPAL_RECORD", Boolean.class, "9f8aa88f-3b5d-47aa-bc60-e3cc507a2e65"); modify this to ExtMap Line 153: } Line 154: Line 155: /** Line 156: * Resource record. -- To view, visit http://gerrit.ovirt.org/26435 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d70daf5e1fc7875458d9091cc814de817223aa0 Gerrit-PatchSet: 39 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
