Yair Zaslavsky has posted comments on this change. Change subject: core: Add selinux host info to VdsDynamic ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/26955/3/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java: Line 349: entity.setHighlyAvailableLocalMaintenance(rs.getBoolean("ha_local_maintenance")); Line 350: entity.setKdumpStatus(KdumpStatus.valueOfNumber(rs.getInt("kdump_status"))); Line 351: entity.calculateFreeVirtualMemory(); Line 352: entity.setBootTime((Long) rs.getObject("boot_time")); Line 353: entity.setSELinuxEnforceMode((Integer) rs.getObject("selinux_enforce_mode")); why getObject and not getInt? Line 354: return entity; Line 355: } Line 356: } http://gerrit.ovirt.org/#/c/26955/3/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java: Line 98: entity.setHardwareFamily(rs.getString("hw_family")); Line 99: entity.setHBAs(new JsonObjectDeserializer().deserialize(rs.getString("hbas"), HashMap.class)); Line 100: entity.setPowerManagementControlledByPolicy(rs.getBoolean("controlled_by_pm_policy")); Line 101: entity.setKdumpStatus(KdumpStatus.valueOfNumber(rs.getInt("kdump_status"))); Line 102: entity.setSELinuxEnforceMode((Integer) rs.getObject("selinux_enforce_mode")); same (getInt, not getObject) Line 103: Line 104: return entity; Line 105: } Line 106: } -- To view, visit http://gerrit.ovirt.org/26955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If472f68702b59280c721450d4db50dc27dc19a30 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
