Yair Zaslavsky has posted comments on this change. Change subject: AAA: Introduce usage of Acct ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/27070/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java: Line 359: if (reportReason == null) { Line 360: reportReason = Acct.ReportReason.PRINCIPAL_LOGIN_FAILED; Line 361: } Line 362: Line 363: AcctUtils.reportAuthRecord(reportReason, result); > no... if you do not have principal you report the user as the end-user spec done - i'll report auth_record and principal. Line 364: if (authResult != Authn.AuthResult.SUCCESS) { Line 365: log.infoFormat( Line 366: "Can't login user \"{0}\" with authentication profile \"{1}\" because the authentication failed.", Line 367: user, -- To view, visit http://gerrit.ovirt.org/27070 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief13d233d11b7ab32b328735b4f58ec7cffff567 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
