Alon Bar-Lev has posted comments on this change. Change subject: utils: introduce universal utilities (uutils) ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/26924/3/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/config/ShellLikeConfd.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/config/ShellLikeConfd.java: Line 21: import org.apache.commons.lang.StringUtils; Line 22: import org.apache.commons.logging.Log; Line 23: import org.apache.commons.logging.LogFactory; Line 24: Line 25: public class ShellLikeConfd { > I'd preferr calling it FileConfiguration, providing some java-doc to explai See above discussion, it is not FileConfiguration, it is configuration for be read by shell as well using source. Previous javadoc were just wrong, not sure what good in these but adding. Line 26: private static final Log log = LogFactory.getLog(ShellLikeConfd.class); Line 27: Line 28: private static final String SENSITIVE_KEYS = "SENSITIVE_KEYS"; Line 29: -- To view, visit http://gerrit.ovirt.org/26924 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
