Hello Omer Frenkel,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/5052
to review the following change.
Change subject: core: make VmBase.isoPath default to empty string
......................................................................
core: make VmBase.isoPath default to empty string
making the VmBase property isoPath to an empty string is defensive coding
against creation of null values when building an XmlRpcStruct which will result
exceptions
and not being able to run actions against VDSM.
while the fix is small, the real solution is to get rid of isoPath since
we have cd information kept in vm_devices already.
Change-Id: I1dc98767943ddfbc18884d87c22e1f1634bc4b65
Signed-off-by: Roy Golan <[email protected]>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/52/5052/1
--
To view, visit http://gerrit.ovirt.org/5052
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1dc98767943ddfbc18884d87c22e1f1634bc4b65
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
