Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: Use custom pg_dump format ......................................................................
Patch Set 6: Verified+1 (1 comment) http://gerrit.ovirt.org/#/c/26073/6/packaging/setup/ovirt_engine_setup/database.py File packaging/setup/ovirt_engine_setup/database.py: Line 708: envAppend={ Line 709: 'PGPASSWORD': '', Line 710: 'PGPASSFILE': self.environment[self._dbenvkeys['pgpassfile']], Line 711: }, Line 712: raiseOnError=False, psql by default returns '0' even if there were sql errors. pg_restore returns 1. Line 713: # TODO: check stderr of this and raise an error if there are real Line 714: # errors. We currently always have one about plpgsql already Line 715: # existing. When doing that, verify with both pg 8 and 9. Line 716: ) -- To view, visit http://gerrit.ovirt.org/26073 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I684f025c9c1d29c701068ba967be5a2115c7a6fb Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
