Kanagaraj M has posted comments on this change. Change subject: ui-plugin : Trends Tab ......................................................................
Patch Set 27: (1 comment) http://gerrit.ovirt.org/#/c/25471/27/gluster-nagios-dashboard/src/js/trends.js File gluster-nagios-dashboard/src/js/trends.js: Line 443: $rootScope.startDate = new Date(yesterday); Line 444: $rootScope.startTime = new Date(yesterday); Line 445: $rootScope.stopDate = new Date(); Line 446: $rootScope.stopTime = new Date(); Line 447: graphs[i] = dataManager.getGraphUtils().trimStartAndStopTimeFromUrl($scope.graphs[i]); > No, circular dependency injections can't be done. dataManager requires grap There is no circular dependency here. When define a service(using factory), it becomes a singleton object. Wherever you refer this service, you will get the same instance. Its like you have services A,B,C B uses A C uses both B and A This is not a circular dependency Line 448: $scope.graphs[i] = graphs[i]; Line 449: } Line 450: }; Line 451: $scope.getCustomGraphs = function() { -- To view, visit http://gerrit.ovirt.org/25471 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7c00636e380da154f7f457066fe89475d04c9b4 Gerrit-PatchSet: 27 Gerrit-Project: samples-uiplugins Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
